Страница 2 из 5

Re: Fade Header

Добавлено: 16.03.2015 12:01
cece74
Full extension:

Edit: No github

Re: Fade Header

Добавлено: 18.03.2015 16:48
zelk
В управлении расширением надо бы добавить возможность выбирать высоту картинок, а то приходится лезть в код и ставить нужную. Ширина автоматом нормально работает.

Re: Fade Header

Добавлено: 19.03.2015 15:40
cece74
Thanks for the advice. I will.

Re: Fade Header

Добавлено: 09.06.2015 17:13
cece74
That's what they told me about .com
I did not understand anything .. help!
1.JPG
2.JPG
http://phpbbextension.altervista.org/fa ... er-t2.html

Re: Fade Header

Добавлено: 09.06.2015 17:17
rxu
cece74, it's in English, so it's pretty hard for us to detail it in English again, and moreover in Russian which won't be understandable for you too :)
I could try to help you but don't know how.

Re: Fade Header

Добавлено: 09.06.2015 17:22
cece74
True, I am Italian and I do not understand anything. Let's see if anyone can help. Thanks anyway.

Re: Fade Header

Добавлено: 09.06.2015 17:34
rxu
Well, if it could be easier for you maybe...
1) You have submitted ver. 1.5, then resubmitted as 1.6, then resubmitted 1.5 again. 1.5 shouldn't go after 1.6.
2) PHPBB should be written as phpBB.
3) Remove instructions.html. Add more explanations to the ACP page instead.
4) Add a comment for the $max_size value about what is it for.
5) Replace all request_var() with $request->variable().
6) Remove '' (empty string) before the $phpbb_root_path.
7) Don't upload files to the extension subdirectory. Use standalone directory instead, or subdir in the /store folder.
8) Before uploading files, check if the directory is writable. If it is not writable, throw error.
9) Remove '' (empty strings) at the end of the template var values.
10) cast $id to int (it looks like (int) $id).
11) In template files, use {L_COLON} instead of :.
12) SLIDE template var is used within JS, so you have to use addslaches on it (it looks like 'SLIDE' => addslaches(substr($slide, 0, -2)),).

Re: Fade Header

Добавлено: 09.06.2015 17:51
cece74
1, 2 ok..
3) Remove instructions.html. - Ok
Add more explanations to the ACP page instead. -- ???
4) ?
5) ?
6) ?
7) And how do I do ?
8) And how do I do?
9) ?
10) ?
11) - OK
12) ?

More than that I do not know what to do ..

Re: Fade Header

Добавлено: 09.06.2015 17:58
владимир1983

Re: Fade Header

Добавлено: 09.06.2015 17:59
cece74
владимир1983 писал(а): cece74, http://www.phpbbitalia.net/forum/?
Yes, is abandoned!

You do not me want?

Re: Fade Header

Добавлено: 09.06.2015 18:12
rxu
cece74 писал(а): Add more explanations to the ACP page instead. -- ???
Put info from the instructions.html here:

Код: Выделить всё

'ACP_FADE_HEADER_EXPLAIN'			=> 'Here you can download the images for the header slider.',
rxu писал(а): 4) Add a comment for the $max_size value about what is it for.

Код: Выделить всё

// Maximum file size, in bytes. We use 50000 because ... (explain the reason here)
$max_size = 500000;
Or better add$max_size config parameter to the ACP.
rxu писал(а): 5) Replace all request_var() with $request->variable().

Код: Выделить всё

		$action		= request_var('action', '');
		$img_id		= request_var('id', 0);

Код: Выделить всё

		$action		= $request->variable('action', '');
		$img_id		= $request->variable('id', 0);
rxu писал(а): 6) Remove '' (empty string) before the $phpbb_root_path.

Код: Выделить всё

$target_dir = $phpbb_root_path . 'ext/sanfi/fadeheader/styles/all/theme/images/';
cece74 писал(а): 7) And how do I do ?

Код: Выделить всё

$target_dir = $phpbb_root_path . 'store/fadeheader/images/';
cece74 писал(а): 8) And how do I do?

Код: Выделить всё

		if($submit)
		{
			if(!phpbb_is_writable($target_dir))
			{
				$error[] = $user->lang['TARGET_DIR_NOT_WRITABLE'];
			}
rxu писал(а): 9) Remove '' (empty strings) at the end of the template var values.

Код: Выделить всё

				'U_MOVE_UP'		=> $this->u_action . '&action=move_up&id=' . $row['id'],
				'U_MOVE_DOWN'	=> $this->u_action . '&action=move_down&id=' . $row['id'],
				'U_DELETE'		=> $this->u_action . '&action=delete&id=' . $row['id'],
rxu писал(а): 10) cast $id to int (it looks like (int) $id).

Код: Выделить всё

		$sql = 'SELECT order_img
			FROM ' . FADE_TABLE . '
			WHERE id = ' . (int) $id;
cece74 писал(а): 12) ?

Код: Выделить всё

		$this->template->assign_vars(array(
			'SLIDE'		=> addslaches(substr($slide, 0, -2)),
			'LAST'		=> substr($last_img, 0, -2),
		));
Отправлено спустя 12 минут 42 секунды:
cece74 писал(а): You do not me want?
feel free to ask help here. It's just a double language barrier ;)

Re: Fade Header

Добавлено: 09.06.2015 19:09
cece74
It puts me in error listner:

Код: Выделить всё

 $this->template->assign_vars(array(
         'SLIDE'      => addslaches(substr($slide, 0, -2)),
         'LAST'      => substr($last_img, 0, -2),
      ));
      

sanfi-fadeheader 1.1.0.zip

Re: Fade Header

Добавлено: 09.06.2015 19:11
rxu
cece74 писал(а): It puts me in error listner:
Yeah, there's a typo, sorry. Should be sh instead of ch

Код: Выделить всё

'SLIDE'      => addslashes(substr($slide, 0, -2)),

Re: Fade Header

Добавлено: 09.06.2015 19:25
cece74
All but did not appear more images. The folder I put it right.
ver 1.1.0.zip
Here:
http://forumseo.edu.jetzt/

Re: Fade Header

Добавлено: 09.06.2015 19:31
rxu
We use 50000 because ... (explain the reason here)
You should replace (explain the reason here) part with actual explanation why it is 500000 and not 1000000 or another value ;)
'store/fadeheader/images/
Does the folder exist and writable (having 777 permissions)?